environment: Use replaceAll()

The replace() function expects two parameters, likely the third one
was ignored. Use replaceAll() to replace all the occurrences, not
just the first one.

Fixes: 007b6ca2e ("environment: Add convenience method for implicit animations")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4084>
(cherry picked from commit 10cd1a875ddaff97b0d2220d2ad7f650da8976df)

diff --git a/js/ui/environment.js b/js/ui/environment.js
index 3ebe8e261a327eabf4677cdc57b19afdb5080d3d..f2dc69eef7832c6c342cca53920b9d92f478797f 100644 (file)
--- a/js/ui/environment.js
+++ b/js/ui/environment.js
@@ -149,7 +149,7 @@ function _easeActor(actor, params) {
     const callback = _makeEaseCallback(params, cleanup);
 
     // cancel overwritten transitions
-    let animatedProps = Object.keys(params).map(p => p.replace('_', '-', 'g'));
+    let animatedProps = Object.keys(params).map(p => p.replaceAll('_', '-'));
     animatedProps.forEach(p => actor.remove_transition(p));
 
     if (easingDuration > 0 || !isReversed)